This repository has been archived by the owner on Jan 22, 2022. It is now read-only.
Set spankind #54
Merged
Set spankind #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the simple example, setting a "SpanKind" of "server" on the parent span will allow spans to be shown in the Summary view of the service in the New Relic UI. I've modified the sample application and the Getting Started guide in the README.md to reflect this.
Instead of seeing a blank Summary view, it'll look like this instead:
Other changes include re-ordering and better grouping of tasks, and a typo fix near the end of the document.