Update to OpenTelemetry 0.18.0 #71
Conversation
newrelic/exporter_test.go
Outdated
| span.SetAttributes(label.Int("depth", depth)) | ||
| span.SetAttributes( | ||
| attribute.Int("depth", depth), | ||
| semconv.ServiceNameKey.String(serviceName), |
There was a problem hiding this comment.
Hi @akulnurislam ! This one has us scratching our heads a bit. What has changed to require us to add this serviceName in order for the test to pass?
There was a problem hiding this comment.
@RichVanderwal ya hahaha, I saw NewExporter doesn't have any setAttributes.
If I look NewExportPipeline there is set attribute serviceName for otel controller.
opentelemetry-exporter-go/newrelic/exporter.go
Lines 111 to 113 in e563425
There was a problem hiding this comment.
@RichVanderwal I've changed set attribute into NewTracerProvider
newrelic/exporter_test.go
Outdated
| r := resource.NewWithAttributes(semconv.ServiceNameKey.String(serviceName)) | ||
|
|
||
| tracerProvider := sdktrace.NewTracerProvider( | ||
| sdktrace.WithBatcher(e, sdktrace.WithBatchTimeout(15), sdktrace.WithMaxExportBatchSize(10)), | ||
| sdktrace.WithResource(r), |
There was a problem hiding this comment.
I think it'd be nice to modify the example app like this as well (adding ServiceName resource here: https://github.com/newrelic/opentelemetry-exporter-go/blob/master/examples/simple/main.go#L57).
There was a problem hiding this comment.
@prmsrswt sure, thanks
There was a problem hiding this comment.
I think this version should go up, after the new release
There was a problem hiding this comment.
a new go.opentelemetry.io/otel v0.19.0 has been released, should this PR be updated to the latest one?
There was a problem hiding this comment.
Indeed. Merging this PR soon as a stepping stone to 0.19.0.
|
@akulnurislam @gunturaf @RichVanderwal @onprem @jodeev We have just released v0.18.0 of our Go OpenTelemetry Exporter which supports OpenTelemetry for Go v0.19.0. Let us know if you have any questions or comments. |
No description provided.