-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-toolkit the hability to release itself (NR-233241) #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20fb62b
to
5abdf6a
Compare
sigilioso
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this!
I've left some comments, let me know your thoughts 🙂
Co-authored-by: Christian <calvarez@newrelic.com>
637d15e
to
9d1efb4
Compare
sigilioso
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks!
Co-authored-by: Christian <calvarez@newrelic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should test its own CHANGELOG.md and have a pipeline that release itself on merge to main.
I took the chance to update a few things on the pipeline. There was a cache mechanism that is not needed anymore with the new version of action/setup-golang
I left al dependencies without being updated on purpose because I would like to add renovatebot and configure its automerge on a future PR.
EDIT:
Now with #188 I tested this in a fork E2E. I change the upstream branc to fork's main so history in the fork is the same history as in this branch except the commit that the release toolkit creates.
You can see tags being created correctly: https://github.com/newrelic-forks/release-toolkit/tags
And a new release: https://github.com/newrelic-forks/release-toolkit/releases/tag/v1.1.0
As a follow PR we can enable renovate to update automatically the repository and see that each PR being merged is going to be released correctly.