Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-toolkit the hability to release itself (NR-233241) #187

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

kilokang
Copy link
Contributor

@kilokang kilokang commented Apr 3, 2024

This should test its own CHANGELOG.md and have a pipeline that release itself on merge to main.

I took the chance to update a few things on the pipeline. There was a cache mechanism that is not needed anymore with the new version of action/setup-golang

I left al dependencies without being updated on purpose because I would like to add renovatebot and configure its automerge on a future PR.

EDIT:

Now with #188 I tested this in a fork E2E. I change the upstream branc to fork's main so history in the fork is the same history as in this branch except the commit that the release toolkit creates.

Screenshot 2024-04-04 at 17 54 50

You can see tags being created correctly: https://github.com/newrelic-forks/release-toolkit/tags
And a new release: https://github.com/newrelic-forks/release-toolkit/releases/tag/v1.1.0

As a follow PR we can enable renovate to update automatically the repository and see that each PR being merged is going to be released correctly.

@kilokang kilokang requested a review from a team April 3, 2024 13:44
@kilokang kilokang changed the title Add release-toolkit the hability to release itself Add release-toolkit the hability to release itself (NR-233241) Apr 3, 2024
@kilokang kilokang marked this pull request as draft April 3, 2024 13:53
@kilokang kilokang force-pushed the feat/release-toolkit-auto-release branch 2 times, most recently from 20fb62b to 5abdf6a Compare April 3, 2024 14:01
@kilokang kilokang marked this pull request as ready for review April 3, 2024 14:05
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

I've left some comments, let me know your thoughts 🙂

@kilokang kilokang force-pushed the feat/release-toolkit-auto-release branch from 637d15e to 9d1efb4 Compare April 4, 2024 15:23
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks!

kilokang and others added 2 commits April 5, 2024 09:34
Co-authored-by: Christian <calvarez@newrelic.com>
@kilokang kilokang merged commit 1f89237 into main Apr 5, 2024
17 checks passed
@kilokang kilokang deleted the feat/release-toolkit-auto-release branch April 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants