fix: minor error clarity improvements

newrelic · Sep 3, 2020 · 63d878b · 63d878b
1 parent 2e60d13
commit 63d878b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -206,7 +206,7 @@ function createRepolinterIssue(client, options) {
             else if (e.status === 403)
                 throw new Error("Creating an issue returned status 403. This is probably due to a scope limitation of your PAT, check that you set the correct permissions (note that GITHUB_TOKEN cannot write repositories other than it's own)");
             else if (e.status === 410)
-                throw new Error('Creating an issue returned status 410, are issues enabled on the repository?');
+                throw new Error('Creating an issue returned status 410, are issues enabled on the target repository?');
             else
                 throw e;
         }
@@ -554,11 +554,10 @@ function run(disableRetry) {
                 core.error(`${requestError.request.method} ${requestError.request.url} returned status ${requestError.status}`);
                 core.debug(JSON.stringify(error));
             }
-            else {
+            else if (error.stack)
+                core.error(error.stack);
+            else
                 core.error(error);
-                if (error.stack)
-                    core.error(error.stack);
-            }
         }
     });
 }

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/createorUpdateIssue.ts b/src/createorUpdateIssue.ts
@@ -211,17 +211,17 @@ export async function createRepolinterIssue(
           : undefined
     })
   } catch (e) {
-    if ((e as RequestError).status === 404)
+    if (e.status === 404)
       throw new Error(
         'Creating an issue returned a 404! Is your token valid/does it have the correct permissions?'
       )
     else if (e.status === 403)
       throw new Error(
         "Creating an issue returned status 403. This is probably due to a scope limitation of your PAT, check that you set the correct permissions (note that GITHUB_TOKEN cannot write repositories other than it's own)"
       )
-    else if ((e as RequestError).status === 410)
+    else if (e.status === 410)
       throw new Error(
-        'Creating an issue returned status 410, are issues enabled on the repository?'
+        'Creating an issue returned status 410, are issues enabled on the target repository?'
       )
     else throw e
   }

diff --git a/src/main.ts b/src/main.ts
@@ -126,9 +126,7 @@ export default async function run(disableRetry?: boolean): Promise<void> {
         `${requestError.request.method} ${requestError.request.url} returned status ${requestError.status}`
       )
       core.debug(JSON.stringify(error))
-    } else {
-      core.error(error as Error)
-      if (error.stack) core.error(error.stack)
-    }
+    } else if (error.stack) core.error(error.stack)
+    else core.error(error)
   }
 }