Update dependencies #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the #[macro_use] before clap because we no longer use the clap_app! macro, because it no longer exists. ¯\_(ツ)_/¯
ListBucketResult changed slightly
Unfortunately google-drive3 really requires hyper <1.0 so we're stuck on 0.14. Also I'm committing this here because I kind of tied to a specific connector and I don't really want to do that long-term, but I also don't want to lose the functional state I have it in right now :D
So this was unfortunate: at some point DriveHub became a DriveHub<S>. Fine, carry the S through, right? Unfortunately some of the downstream calls (specifically anything after the "activity" e.g. files()) require specific trait bounds -- which means everything you pass the DriveHub<S> to has to enforce those trait bounds. This *would* be fine if the DriveHub<S> were just a *member* of the struct: we could specify S and its bounds once and not have to worry about it, but that would require a more thorough rewrite, which I can't fully test without access to certain things. So I settled for using the trait bounds required downstream as well everywhere, which adds about five lines everywhere, but at least required very little further modification to get the same functionality.
|
|
one for JSON, one for Windows
noahmmcgivern
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies used by rusty-hog apps
The biggest update is probably clap: I had to move away from the macros and directly use their
Command::newandArg*::*interfaces.Base64 completely updated their interfaces to use something more engine-based.
Hyper completely re-did their interfaces for v1.0 and so I was unable to move to that, because google-drive3 depends on the interfaces to v0.14-ish. I believe they vendor it now so it may be possible to work with that down the line as well, however.
Some services the hogs use I don't have any access to, so I wasn't able to test them directly -- I'm kind of hoping the fact that they compile means they should work, unfortunately.