Cloud watch filter #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolanos
reviewed
Nov 19, 2019
There was a problem hiding this comment.
Thanks for this contribution @justinrcs. It's definitely a feature we've been meaning to add. Only question is relating to the catch-all filter option.
src/index.ts
Outdated
| @@ -75,6 +75,18 @@ export default class NewRelicLambdaLayerPlugin { | |||
|
|
|||
| public async addLogSubscriptions() { | |||
| const funcs = this.functions; | |||
| let { cloudWatchFilter = [ "NR_LAMBDA_MONITORING" ] } = this.config; | |||
|
|
|||
| if(cloudWatchFilter.length == 1 && cloudWatchFilter[0] == "*") { | |||
There was a problem hiding this comment.
Why delete the first item here? Wouldn't it be better to iterate over the array looking for * and if found just set the filter pattern to ""?
There was a problem hiding this comment.
The thinking here was if you wanted all the logs, you wouldn't provide a list of filters, just the one. i will make the change as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional configuration to specify a custom filter for the CloudWatch log subscription.
Configuration defaults to the standard "NR_LAMBDA_MONITORING" filter.
If the filter is configured as "*" it will capture all logs.
If multiple filters are provided they are combined into an OR filter.