Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodejs12.x Support #12

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Add nodejs12.x Support #12

merged 1 commit into from
Nov 19, 2019

Conversation

kolanos
Copy link
Contributor

@kolanos kolanos commented Nov 19, 2019

Closes #10

@kolanos kolanos requested a review from mrickard November 19, 2019 13:56
@kolanos kolanos self-assigned this Nov 19, 2019
mrickard
mrickard reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@mrickard mrickard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right! Though...apparently the latest sls doesn't support the node 12 runtime yet! (Just tested; sls warns about that, but goes ahead with deploy anyway.)

@kolanos kolanos merged commit e3e01dc into master Nov 19, 2019
@kolanos kolanos deleted the issue/10 branch November 19, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrickard mrickard mrickard approved these changes

Assignees

@kolanos kolanos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nodejs12.x Support
2 participants
@kolanos @mrickard