Skip to content

Commit

Permalink
fix: Recreate Synthetics resources on account ID change (#2518)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbazhlekova authored Dec 13, 2023
1 parent 6981577 commit b348462
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions newrelic/resource_helpers_synthetics.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ func syntheticsMonitorCommonSchema() map[string]*schema.Schema {
"account_id": {
Type: schema.TypeInt,
Description: "ID of the newrelic account.",
ForceNew: true,
Computed: true,
Optional: true,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func TestAccNewRelicCloudAzureIntegration_Basic(t *testing.T) {
testAzureIntegrationName := fmt.Sprintf("tf_cloud_integrations_test_azure_%s", acctest.RandString(5))
resourceName := "newrelic_cloud_azure_integrations.bar"

// t.Skip("Skipping test until we can get a better Azure test account")
t.Skipf("Skipping test until we can get a better Azure test account")

if subAccountIDExists := os.Getenv("NEW_RELIC_SUBACCOUNT_ID"); subAccountIDExists == "" {
t.Skipf("Skipping this test, as NEW_RELIC_SUBACCOUNT_ID must be set for this test to run.")
Expand Down
2 changes: 2 additions & 0 deletions newrelic/resource_newrelic_cloud_azure_link_account_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ func TestAccNewRelicCloudAzureLinkAccount_Basic(t *testing.T) {
testAzureLinkAccountName := fmt.Sprintf("tf_cloud_link_account_test_azure_%s", acctest.RandString(5))
resourceName := "newrelic_cloud_azure_link_account.foo"

t.Skipf("Skipping test until we can get a better Azure test account")

if subAccountIDExists := os.Getenv("NEW_RELIC_SUBACCOUNT_ID"); subAccountIDExists == "" {
t.Skipf("Skipping this test, as NEW_RELIC_SUBACCOUNT_ID must be set for this test to run.")
}
Expand Down
1 change: 1 addition & 0 deletions newrelic/resource_newrelic_synthetics_private_location.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func resourceNewRelicSyntheticsPrivateLocation() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Computed: true,
ForceNew: true,
Description: "The ID of the account in New Relic.",
},
"description": {
Expand Down
1 change: 1 addition & 0 deletions newrelic/resource_newrelic_synthetics_secure_credential.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ func resourceNewRelicSyntheticsSecureCredential() *schema.Resource {
Type: schema.TypeInt,
Optional: true,
Computed: true,
ForceNew: true,
Description: "The New Relic account ID where you want to create the secure credential.",
},
"key": {
Expand Down

0 comments on commit b348462

Please sign in to comment.