Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update docs for slow burn alerts #2476

Merged

Conversation

akane0915
Copy link
Collaborator

@akane0915 akane0915 commented Oct 2, 2023

Description

The documentation for NRQL alert conditions should be updated to reflect the updated allowed maximum for aggregation_window and the corresponding slide-by changes.

Fixes (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Ensure updated documentation makes sense and reflects the goals described in the ticket.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

@akane0915 akane0915 force-pushed the NR-113483/slow_burn_alerts_doc_updates branch from f3517e8 to 40646b4 Compare October 2, 2023 15:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #2476 (9a45f35) into main (947f861) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2476   +/-   ##
=======================================
  Coverage   33.82%   33.82%           
=======================================
  Files          91       91           
  Lines       24918    24918           
=======================================
  Hits         8429     8429           
  Misses      16333    16333           
  Partials      156      156           
Files Coverage Δ
newrelic/resource_newrelic_nrql_alert_condition.go 30.66% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@akane0915
Copy link
Collaborator Author

@mbazhlekova Please do not merge this PR yet. It is not ready. I'll let you know when it's ready. Thank you!

@akane0915 akane0915 force-pushed the NR-113483/slow_burn_alerts_doc_updates branch from 40646b4 to 9a45f35 Compare November 9, 2023 16:38
@akane0915
Copy link
Collaborator Author

@mbazhlekova This is ready to be merged and released now. Thank you!

@mbazhlekova mbazhlekova merged commit 640c7f2 into newrelic:main Nov 9, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants