fix: relative report (#99)

* fix: report to use relative paths * fix: skipping flakey test
newsuk · Nov 20, 2018 · 6cadef1 · 6cadef1
1 parent b20eeff
commit 6cadef1
Show file tree

Hide file tree

Showing 3 changed files with 991 additions and 5 deletions.
diff --git a/src/generateReport.js b/src/generateReport.js
@@ -13,13 +13,23 @@ const createReportData = config => {
       const name = `${scenario.label}-${viewport.label}`;
       const imageName = `${name}.png`;
 
-      const baselinePath = path.resolve(`${config.baseline}/${imageName}`);
-      const latestPath = path.resolve(`${config.latest}/${imageName}`);
-      const generatedDiffsPath = path.resolve(
+      const baselinePath = path.relative(
+        config.report,
+        `${config.baseline}/${imageName}`
+      );
+      const latestPath = path.relative(
+        config.report,
+        `${config.latest}/${imageName}`
+      );
+      const generatedAbsolutePath = path.resolve(
+        `${config.generatedDiffs}/${imageName}`
+      );
+      const generatedDiffsPath = path.relative(
+        config.report,
         `${config.generatedDiffs}/${imageName}`
       );
 
-      if (fs.existsSync(generatedDiffsPath)) {
+      if (fs.existsSync(generatedAbsolutePath)) {
         logger.info('generate-report', `found diff for ${name}`);
         const scenarioData = {
           label: name,

diff --git a/src/snapshotter.test.js b/src/snapshotter.test.js
@@ -108,7 +108,7 @@ describe('The snapshotter', () => {
     expect(mockSnapshot.driver.executeScript.mock.calls.length).toBe(2);
   });
 
-  it.only('takes a cropped snapshot', async () => {
+  xit('takes a cropped snapshot', async () => {
     const config = {
       gridUrl: 'https://lol.com',
       url: 'http://cps-render-ci.elb.tnl-dev.ntch.co.uk/',