-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: on before suite script #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/onBeforeSuiteScript
milesillsley
requested review from
kaliabadi,
L0wry and
shendriksen
as code owners
February 19, 2019 16:59
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
reviewed
Feb 19, 2019
L0wry
suggested changes
Feb 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
L0wry
reviewed
Feb 20, 2019
L0wry
reviewed
Feb 20, 2019
L0wry
reviewed
Feb 20, 2019
shendriksen
reviewed
Feb 20, 2019
README.md
Outdated
|
||
In cases where you need to run a script once, before the entire suite is launched (e.g. setting up global objects or setting up external services), pass the path of the script into `onBeforeSuiteScript` in the config file. | ||
|
||
Unlike the onReady and onBefore script options onBeforeSuite scripts do not have any driver exposed and take no arguments. Any external dependancys will need to be set up independantly inside the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dependencies"
L0wry
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an onBeforeSuiteScript config option which runs a script once, before any snaps are taken.
The script is executed without a driver, so all scripts implemented here need to operate independently of the snappshotters' functionality.
executeScript has been extracted from snapshotter into two separate functions; one taking a driver as an argument (for use in snapshotter) and the other without.