conn: add support for timeout #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrezina
force-pushed
the
timeout
branch
3 times, most recently
from
c173777 to
4fa9287
Compare
Default timeout is 300 seconds. This can be changed using timeout parameter of: * conn.run(timeout=xy) * conn.exec(timeout=xy) * process.wait(timout=xy) Or in mhc.yaml by setting host.conn.timeout.
thalman
suggested changes
Feb 5, 2025
Comment on lines
+500
to
+503
| if self.blocking_call and self.log_level != ProcessLogLevel.Error: | ||
| self._log_result_sync(result) | ||
| else: | ||
| self._log_result_async(result) |
There was a problem hiding this comment.
Checking self.log_level here seems redundant (it is checked in _log_result...) and makes the condition less readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.