Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matomo as an analytics provider #553

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

foliet
Copy link
Contributor

@foliet foliet commented Aug 2, 2022

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

There's no support for Matomo Analytics
Issue resolved: None

What is the new behavior?

Simple change. It does work if you can see three http requests about matomo as shown below.

  • Link to demo site with this changes: None
  • Screenshots with this changes:
    image

How to use?

In NexT _config.yml, line 696:

# Matomo Analytics
# See: https://matomo.org/
matomo:
  enable: false
  server_url: # https://www.example.com/
  site_id: # <your site id>

Notes

I haven't updated the docs and I will finish it after this PR being accepted. This is my first PR in my life, so please correct me if there is any mistake.

@welcome
Copy link

welcome bot commented Aug 2, 2022

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2022

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2784829291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%

Totals Coverage Status
Change from base Build 2772219653: 0.0%
Covered Lines: 138
Relevant Lines: 141

💛 - Coveralls

@stevenjoezhang stevenjoezhang merged commit 017a974 into next-theme:master Aug 22, 2022
@welcome
Copy link

welcome bot commented Aug 22, 2022

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants