-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): Add Loops Email Provider and Documentation #11197
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@Whats-A-MattR is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Pls approve. |
How about we get some merge happening @ndom91 @ThangHuuVu @ubbe-xyz |
bumping again |
updating from base (again). |
@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please? |
Please don't tag maintainers directly 🙏 Regarding getting this in, are the extra types you added back really necessary? Look at how simple the other email providers are for example. |
To include the transactionalId without the LSP complaining, type errors being thrown, and the build and test scripts failing I had to do the typing. The other providers are unaffected as all I did was type the props of a function in the interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sounds good, lets go with this for now then. Sorry for the long PR process.
By "look at the other email providers.." all I meant was look at how simple their types are.
🙏🏻 No dramas, just happy to have this added 😄 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11197 +/- ##
==========================================
- Coverage 39.64% 39.52% -0.12%
==========================================
Files 192 193 +1
Lines 30465 30552 +87
Branches 1331 1338 +7
==========================================
Hits 12077 12077
- Misses 18388 18475 +87 ☔ View full report in Codecov by Sentry. |
☕️ Reasoning
Email / Magic Token Auth is great.
Loops.so make a great product for Email that goes beyond just transactional emails, I use them as my provider and love the platform.
🧢 Checklist
🎫 Affected issues
Fixes: This Feature Request
📌 Resources