Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): Add Loops Email Provider and Documentation #11197

Merged
merged 58 commits into from
Nov 27, 2024

Conversation

Whats-A-MattR
Copy link
Contributor

☕️ Reasoning

Email / Magic Token Auth is great.
Loops.so make a great product for Email that goes beyond just transactional emails, I use them as my provider and love the platform.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: This Feature Request

📌 Resources

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 1:23pm

Copy link

vercel bot commented Jun 18, 2024

@Whats-A-MattR is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@Whats-A-MattR Whats-A-MattR changed the title Add Loopa.so as Email Provider Add Loops.so as Email Provider Jun 18, 2024
@Whats-A-MattR Whats-A-MattR changed the title Add Loops.so as Email Provider Add Loops.so Email Provider and Documentation Jun 18, 2024
@github-actions github-actions bot added providers core Refers to `@auth/core` labels Jun 18, 2024
@Whats-A-MattR Whats-A-MattR marked this pull request as ready for review June 18, 2024 06:40
@Whats-A-MattR Whats-A-MattR changed the title Add Loops.so Email Provider and Documentation Add Loops Email Provider and Documentation Jun 18, 2024
@Whats-A-MattR Whats-A-MattR changed the title Add Loops Email Provider and Documentation Feat(providers): Add Loops Email Provider and Documentation Jun 18, 2024
@Whats-A-MattR
Copy link
Contributor Author

Pls approve.

@Whats-A-MattR
Copy link
Contributor Author

How about we get some merge happening @ndom91 @ThangHuuVu @ubbe-xyz
Should all be ready to go

@Whats-A-MattR
Copy link
Contributor Author

How about we get some merge happening @ndom91 @ThangHuuVu @ubbe-xyz Should all be ready to go

bumping again

@Whats-A-MattR
Copy link
Contributor Author

updating from base (again).

@Whats-A-MattR
Copy link
Contributor Author

@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please?

@ndom91
Copy link
Member

ndom91 commented Oct 28, 2024

@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please?

Please don't tag maintainers directly 🙏

Regarding getting this in, are the extra types you added back really necessary? Look at how simple the other email providers are for example.

@Whats-A-MattR
Copy link
Contributor Author

@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please?

Please don't tag maintainers directly 🙏

Regarding getting this in, are the extra types you added back really necessary? Look at how simple the other email providers are for example.

To include the transactionalId without the LSP complaining, type errors being thrown, and the build and test scripts failing I had to do the typing.

The other providers are unaffected as all I did was type the props of a function in the interface.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sounds good, lets go with this for now then. Sorry for the long PR process.

By "look at the other email providers.." all I meant was look at how simple their types are.

@Whats-A-MattR
Copy link
Contributor Author

Okay sounds good, lets go with this for now then. Sorry for the long PR process.

By "look at the other email providers.." all I meant was look at how simple their types are.

🙏🏻

No dramas, just happy to have this added 😄

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 96 lines in your changes missing coverage. Please review.

Project coverage is 39.52%. Comparing base (3df6ff9) to head (0bdb5e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/providers/loops.ts 0.00% 79 Missing ⚠️
packages/core/src/providers/email.ts 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11197      +/-   ##
==========================================
- Coverage   39.64%   39.52%   -0.12%     
==========================================
  Files         192      193       +1     
  Lines       30465    30552      +87     
  Branches     1331     1338       +7     
==========================================
  Hits        12077    12077              
- Misses      18388    18475      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit 3ec0684 into nextauthjs:main Nov 27, 2024
11 of 15 checks passed
@Whats-A-MattR Whats-A-MattR deleted the email-docs-fix branch December 3, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants