Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update errors page with more details #2196

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Jun 16, 2021

Reasoning 💡

Updated the docs errors page to flesh out the descriptions of each possible event.

I tried to scour the code and do some research on all missing ones, but if I misunderstood one of the them, etc. feel free to change it wink

I couldn't find those database errors towards the bottom anywhere in the code anymore, not in adapters nor core, so all the ones with "N/A" can technically be removed I think. What do you think?

Checklist 🧢

  • Documentation
  • [ ] Tests
  • Ready to be merged

Affected issues 🎟

Fixes #1089

@ndom91 ndom91 requested a review from balazsorban44 June 16, 2021 08:21
@vercel
Copy link

vercel bot commented Jun 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/5wdpPECNim32X7TbB9bdWaUQuFdP
✅ Preview: https://next-auth-git-ndom91-docsupdate-errors-page-nextauthjs.vercel.app

@ndom91 ndom91 mentioned this pull request Jun 16, 2021
2 tasks
@github-actions github-actions bot added the docs Relates to documentation label Jun 16, 2021
@ndom91 ndom91 changed the title Ndom91/docs/update errors page docs: update errors page with more details Jun 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #2196 (da4c263) into next (bbc2d9b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            next   #2196      +/-   ##
========================================
- Coverage   9.99%   9.96%   -0.03%     
========================================
  Files         82      83       +1     
  Lines       1391    1395       +4     
  Branches     382     382              
========================================
  Hits         139     139              
- Misses      1032    1036       +4     
  Partials     220     220              
Impacted Files Coverage Δ
src/providers/naver.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc2d9b...da4c263. Read the comment docs.

Copy link
Collaborator

@ubbe-xyz ubbe-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 🙌🏽

www/docs/errors.md Outdated Show resolved Hide resolved
Co-authored-by: Lluis Agusti <hi@llu.lu>
@vercel vercel bot temporarily deployed to Preview June 20, 2021 08:43 Inactive
@ubbe-xyz ubbe-xyz merged commit 3a48b8e into next Jun 22, 2021
@ubbe-xyz ubbe-xyz deleted the ndom91/docs/update-errors-page branch June 22, 2021 18:15
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants