New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): expose Web API compatible version of `next-auth` #5536

Merged

balazsorban44 merged 113 commits into main from feat/oauth4webapi-balazs

Dec 13, 2022

Member

balazsorban44 commented Oct 10, 2022 •

edited

Loading

Introducing next-auth/web, a fully Web API compatible version of NextAuth.js.

Supersedes #4299

This PR is based on #4769, which has to be merged first. (Diff is therefore currently bigger than it is supposed to be.)

crypto interop
authorization endpoint
callback (token & userinfo endpoints)
Node.js/Web interop in core (this should probably not be needed. 🤔)

balazsorban44 added 30 commits

June 26, 2022 21:24


          WIP use Request and Response for core

e428b17


          Merge branch 'main' into chore/core-request-response


          bump Next.js

8c21589


          rename ts types

504f384


          refactor

c736948


          simplify

b274e98


          upgrade Next.js

b933003


          implement body reader

db6b1c9


          use Request/Response in next-auth/next

fe9c6a5


          make linter happy

bc9ddae


          revert

a5cd972


          fix tests

2cf11bb


          remove workaround for middleware return type

63cdea4


          Merge branch 'main' into chore/core-request-response

eb77e23


          return session in protected api route example

1903e3c


          don't export internal handler

b63e843


          fall back host to localhost

07ab4f8


          refactor getBody

415d299


          refactor next-auth/next

b41bdeb


          Merge branch 'main' into chore/core-request-response

8f7288a


          chore: add @edge-runtime/jest-environment

bd4d78b


          fix tests, using Node 18 as runtime

1a2e752


          fix test

195822c


          remove patch

57a7d3f


          upgrade/add dependencies

3d14536


          type and default import on one line

bc314ef


          don't import all adapters by default in dev


          simplify internal endpoint config

b8ed735

Instead of passing url and params around as a string and an object,
we parse them into a `URL` instance.


          assert if both endpoint and issuer config is missing

9bea473


          allow internal redirect to be URL

cbd7f18


          update gitignore

2c209d7

balazsorban44 had a problem deploying to Preview

December 13, 2022 12:59

— with

GitHub Actions Failure


          update exports field

balazsorban44 had a problem deploying to Preview

December 13, 2022 13:02

— with

GitHub Actions Failure

github-advanced-security bot found potential problems

View reviewed changes

packages/core/src/lib/pages/signin.tsx

+                    {theme.brandColor && (
+                      <style
+                        dangerouslySetInnerHTML={{
+                          __html: `:root {--brand-color: ${theme.brandColor}}`,

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.

packages/core/src/lib/pages/signin.tsx

+                        }}
+                      />
+                    )}
+                    {theme.logo && <img src={theme.logo} alt="Logo" className="logo" />}

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.

packages/core/src/lib/pages/signin.tsx

+                      {providers.map((provider, i) => (
+                        <div key={provider.id} className="provider">
+                          {provider.type === "oauth" || provider.type === "oidc" ? (
+                            <form action={provider.signinUrl} method="POST">

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.

packages/core/src/lib/pages/signin.tsx

Comment on lines +108 to +110

+                                    src={`${
+                                      provider.style.logo.startsWith("/") ? logos : ""
+                                    }${provider.style.logo}`}

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.

packages/core/src/lib/pages/signin.tsx

Comment on lines +116 to +118

+                                    src={`${
+                                      provider.style.logo.startsWith("/") ? logos : ""
+                                    }${provider.style.logoDark}`}

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.

packages/core/src/lib/pages/signin.tsx

+                            providers[i - 1].type !== "email" &&
+                            providers[i - 1].type !== "credentials" && <hr />}
+                          {provider.type === "email" && (
+                            <form action={provider.signinUrl} method="POST">

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.

packages/core/src/lib/pages/signin.tsx

+                            </form>
+                          )}
+                          {provider.type === "credentials" && (
+                            <form action={provider.callbackUrl} method="POST">

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.


          revert next-auth

fef8457

github-actions bot removed providers core client style TypeScript labels

balazsorban44 added 7 commits

December 13, 2022 14:07


          remove extra tsconfig files

ced1ca4


          remove private from package.json

369a27b


          remove unused file, expose type

df061b9


          move gitignore, reduce exposed types

18b8247


          add back tsconfig files

6c098d7


          remove leftover

1d1dfb7


          Merge branch 'main' into feat/oauth4webapi-balazs

c2e40f0

vercel bot had a problem deploying to Preview

December 13, 2022 17:04

Failure


          revert gitignore

34e4471

balazsorban44 marked this pull request as ready for review

December 13, 2022 18:17

balazsorban44 requested review from ubbe-xyz, ThangHuuVu and ndom91 as code owners

December 13, 2022 18:17

ThangHuuVu approved these changes

View reviewed changes

Member

ThangHuuVu left a comment

LFG 🚢


          remove test script

ef3dbfb

balazsorban44 had a problem deploying to Preview

December 13, 2022 18:21

— with

GitHub Actions Failure

balazsorban44 merged commit a7b6a29 into main

balazsorban44 deleted the feat/oauth4webapi-balazs branch

December 13, 2022 18:24

cryptiklemur commented Dec 13, 2022

Any docs on using this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hmnd hmnd left review comments

panva panva left review comments

ThangHuuVu ThangHuuVu approved these changes

ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

Labels

None yet