Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add save/restore state commands #627

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: Add save/restore state commands #627

merged 1 commit into from
Sep 17, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 15, 2024

No description provided.

@artonge artonge added 3. to review Waiting for reviews enhancement New feature request labels Sep 15, 2024
@artonge artonge requested review from susnux and skjnldsv September 15, 2024 11:42
@artonge artonge self-assigned this Sep 15, 2024
@artonge artonge force-pushed the artonge/feat/save_restore_state branch from 38f3b6e to 1565243 Compare September 15, 2024 11:44
skjnldsv
skjnldsv reviewed Sep 16, 2024
View reviewed changes
lib/index.ts Outdated Show resolved Hide resolved
skjnldsv
skjnldsv reviewed Sep 16, 2024
View reviewed changes
lib/index.ts Outdated Show resolved Hide resolved
skjnldsv
skjnldsv requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using the nextcloud-cypress-tests_groupfolders container name 🙈

@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 17, 2024 •
edited
Loading

I remember I also did this already a month ago https://github.com/nextcloud-libraries/nextcloud-cypress/blob/main/lib/commands/snapshots.ts

Wanna add te data part to it instead?
I also prefer your methods names. If you wanna adjust them too 😉

@artonge
Copy link
Contributor Author

artonge commented Sep 17, 2024

Ah, I looked for that but couldn't find it. Let me upgrade it

@artonge
Copy link
Contributor Author

artonge commented Sep 17, 2024

Ah, I was looking in the master branch 🙈

@artonge artonge force-pushed the artonge/feat/save_restore_state branch 3 times, most recently from 3706713 to 632a616 Compare September 17, 2024 09:12
@artonge artonge requested a review from skjnldsv September 17, 2024 09:13
@artonge artonge force-pushed the artonge/feat/save_restore_state branch 2 times, most recently from f9572cb to 4fb5391 Compare September 17, 2024 10:05
@artonge
feat!: Add save/restore state commands
140863e 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/save_restore_state branch from 4fb5391 to 140863e Compare September 17, 2024 10:09
@artonge artonge enabled auto-merge September 17, 2024 10:09
@artonge artonge merged commit e5cb46f into main Sep 17, 2024
12 checks passed
@artonge artonge deleted the artonge/feat/save_restore_state branch September 17, 2024 10:12
@artonge artonge mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @skjnldsv