-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Undo method & translations #106
Conversation
skjnldsv
commented
Mar 23, 2020
•
edited
Loading
edited
- Toastify upstream Add option to provide a node instead of text apvarun/toastify-js#54
- Cleanup
- Undo method
- Translate
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I’d rather we have the work here centrally, than have to check it in every single place. The action and UI is standardized and so should the wording and how it is displayed. It will ease the work for all developers, and make it consistent for all users. If we don’t do that, at least make sure the wording recommendations are in the documentation (which hopefully all devs will read). |
This comment has been minimized.
This comment has been minimized.
7c9a32d
to
f43bb7b
Compare
All good! Please review everyone 🎉 |
e53a6b4
to
e29b5bd
Compare
So, it seems something broke, I don't understand why. Or anyone, It seems it's a config issue where the imports are weird misbehaving. I don't understand why |
a3e2494
to
b92d39d
Compare
# | ||
# Translators: | ||
# Brendan Abolivier <transifex@brendanabolivier.com>, 2020 | ||
# gud bes <gudbes@protonmail.com>, 2020 | ||
# Greg Greg <grena@grenabox.fr>, 2020 | ||
# Luclu7 <theluc7andcompagnie@gmail.com>, 2020 | ||
# Julien Veyssier <eneiluj@gmx.fr>, 2020 | ||
# | ||
msgid "" | ||
msgstr "" | ||
"Last-Translator: Julien Veyssier <eneiluj@gmx.fr>, 2020\n" | ||
"Language-Team: French (https://www.transifex.com/nextcloud/teams/64236/fr/)\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Language: fr\n" | ||
"Plural-Forms: nplurals=2; plural=(n > 1);\n" | ||
|
||
#: src/components/MultiselectTags/MultiselectTags.vue:170 | ||
#: lib/toast.ts:187 | ||
msgid "Undo" | ||
msgstr "Annuler" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dummy file, will get overrided, it's fine
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
} | ||
|
||
export interface ToastOptions { | ||
/** | ||
* Defines the timeout after which the toast is closed. Set to 0 to have a persistent toast. | ||
* Defines the timeout after which the toast is closed. Set to -1 to have a persistent toast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.