Add filepicker filter #577
Conversation
|
@PVince81 any questions about this that we need to discuss? |
|
|
||
| public constructor(title: string, | ||
| multiSelect: boolean, | ||
| mimeTypeFilter: string[], | ||
| modal: boolean, | ||
| type: FilePickerType, | ||
| directoriesAllowed: boolean, | ||
| path?: string) { | ||
| path?: string, | ||
| filter?: Nextcloud.v24.FilePickerFilter) { |
There was a problem hiding this comment.
am not familiar enough with Typescript to be able to decide whether it's a good idea to define the filter this way
@ChristophWurst can you confirm ?
There was a problem hiding this comment.
Right. That would wrongly indicate that the argument is available for 22 and 23 as well, doesn't it?
There was a problem hiding this comment.
I believe @PVince81 is referring to the Nextcloud.v24.FilePickerFilter type which makes sense to me as it's definition and functionality is stable as per nextcloud/server#31972 introduced in Nextcloud 24, otherwise I guess we could have a Nextcloud.Stable namespace in https://github.com/nextcloud/nextcloud-typings but is maybe not worth the upkeep
I'd suggest we just bump the major version of this package when releasing, @ChristophWurst @PVince81 thoughts?
There was a problem hiding this comment.
Yep, should be a major version
|
What is the status here? |
As stated above #577 (comment) I'm fine with bumping the major and releasing so good from my side but I can't approve as I opened this :) Look good @PVince81 @ChristophWurst? |
Pytal
force-pushed
the
feat/filter
branch
2 times, most recently
from
f65d2d7 to
466bbd3
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Close #560