Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark mode with Nextcloud 25 #630

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Fix dark mode with Nextcloud 25 #630

merged 1 commit into from
Jul 21, 2022

Conversation

nickvergessen
Copy link
Contributor

Fix #629

Before

  • 24 👍🏼
  • 25
    • Normal
      Bildschirmfoto vom 2022-07-21 11-21-41
    • Keyboard hover
      Bildschirmfoto vom 2022-07-21 11-21-48

After

Mode Nextcloud 24 Nextcloud 25 (Sorry for the 120% zoom)
Bright mode Bildschirmfoto vom 2022-07-21 12-23-36 Bildschirmfoto vom 2022-07-21 12-09-18
Bright mode keyboard hover Bildschirmfoto vom 2022-07-21 12-23-27 Bildschirmfoto vom 2022-07-21 12-09-10
Dark mode Bildschirmfoto vom 2022-07-21 12-23-16 Bildschirmfoto vom 2022-07-21 12-09-23
Dark mode keyboard hover Bildschirmfoto vom 2022-07-21 12-23-21 Bildschirmfoto vom 2022-07-21 12-09-33

@nickvergessen
Fix darkmmode with Nextcloud 25
cdcc469 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the bug Something isn't working label Jul 21, 2022
@nickvergessen nickvergessen changed the title Fix darkmmode with Nextcloud 25 Fix dark mode with Nextcloud 25 Jul 21, 2022
@nickvergessen nickvergessen mentioned this pull request Jul 21, 2022
Closed
PVince81
PVince81 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 253fbae into master Jul 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/fix-darkmode-wiht-nextcloud-25 branch July 21, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toastify dark mode regression
2 participants
@nickvergessen @PVince81