Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more translation tests #570

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Add more translation tests #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d28308
feat(tests): Added more testcases for translation functions
susnux Jan 22, 2023
84fa496
fix(translation): Fix singular translation in edge cases where plural…
susnux Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/translation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,12 @@ export function translate(
}

const bundle = getAppTranslations(app)
const translation = bundle.translations[text] || text
let translation = bundle.translations[text] || text
translation = Array.isArray(translation) ? translation[0] : translation

if (typeof vars === 'object' || number !== undefined) {
return optSanitize(_build(
typeof translation === 'string' ? translation : translation[0],
translation,
vars,
number
))
Expand Down
142 changes: 0 additions & 142 deletions tests/index.test.js
View file
Open in desktop

This file was deleted.

Loading