Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor!: Make package using modules and type only #261

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 1, 2024

Brace yourself the diff is huge!
This is a complete refactor of the library and contains this changes:

  1. (breaking!) Make the package use modules instead of namespaces, this is the recommended way since ES modules are part of the language. This also fixes some weird behavior of referencing types with Typescript 5.5. Moreover this allows to separate the code better and reuse parts that we use later (probably) for new versions.
  2. Consolidate all types into Nextcloud28 as this is the oldest supported version. This allows to cleanup the code a bit.
  3. Add NextcloudLatest alias type export
  4. Use ESLint for code linting
  5. Use Prettier to enforce consistent code style
  6. Add SPDX headers and make package REUSE compliant

@AndyScherzinger
Copy link
Contributor

Add SPDX headers and make package REUSE compliant

Already on master @susnux - you might want to rebase

@susnux
Copy link
Contributor Author

susnux commented Jul 8, 2024

@AndyScherzinger thank you, done :)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… modules instead of namespaces

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants