-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for chunked upload v2 - S3 multipart upload #924
Comments
Would be a regression for 28 if we don't do that, I can check this somewhen next week. |
Interesting! Though, shall we ever support the v1 ? |
There is a Limitation as the maximum possible upload size got a file would be 5TB and the chunk size needs to be increased dynamically in case the filesize doesn't fit in 10.000 chunks of the default 10MB chunk size (but that would be for files >100gb). So overall nothing I would consider worth keeping two implementations, especially since this would then still only help for local storage as s3 always had those limitations. Also uploading 100gb in 10 mb chunks doesn't make much sense at all in terms of performance. Hope that makes it a bit clearer :) |
How does the front decides which to use then? |
It does not need to, new api calls are backward compatible with the old backend. |
Fixed by #925 |
We need to adapt the chunked upload bits to also work with nextcloud/server#27034
documented in nextcloud/documentation#10740
The text was updated successfully, but these errors were encountered: