-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement support for chunking v2 API #925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
==========================================
+ Coverage 91.54% 92.10% +0.55%
==========================================
Files 3 3
Lines 71 76 +5
Branches 11 14 +3
==========================================
+ Hits 65 70 +5
+ Misses 4 3 -1
- Partials 2 3 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like how small the changes look! Makes me feel good about the first implementation in the first place! 🚀
Type 'undefined' is not assignable to type 'number'.
1 export const getMaxChunksSize = function(fileSize: number = undefined): number {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/utils/upload.ts:15:129 - error TS2322: Type 'undefined' is not assignable to type 'string'.
15 export const uploadData = async function(url: string, uploadData: UploadData, signal: AbortSignal, onUploadProgress = () => {}, destinationFile: string = undefined): Promise<AxiosResponse> {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/utils/upload.ts:63:50 - error TS2322: Type 'undefined' is not assignable to type 'string'. |
Pushed type fixes and two more tests covering the relevant headers |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
8457782
to
9da6748
Compare
Implements #924
Tested locally to work with S3 primary storage with server master