Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assembling status to UploadPicker #1530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 18, 2024

image

@Koc here is my take on this.
I think adding some text to the right isn't the right approach.
Now we make sure we don't have any ongoing upload that are NOT assembling
If all is left is assembling tasks, we show the status.

  • Assembling status uploader fix
  • Assembling status vue component feat
  • Cypress tests

Closes #1458

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Dec 18, 2024
@skjnldsv skjnldsv requested review from susnux, artonge and nfebe December 18, 2024 18:16
@skjnldsv skjnldsv self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Bundle Report

Changes will increase total bundle size by 1.33kB (0.17%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@nextcloud/upload-esm 396.52kB 666 bytes (0.17%) ⬆️
@nextcloud/upload-cjs 399.88kB 666 bytes (0.17%) ⬆️

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@Koc
Copy link
Contributor

Koc commented Dec 19, 2024

@skjnldsv Awesome! But it still not works for me. Reproducer:

  1. set max chunk size to 40 Mb
  2. upload 2 files in parallel: 35 Mb (smaller than chunk to have regular upload) and 150 Mb (few times bigger than chunk to have chunked upload)

Expected: Progressbar shows upload progress and assembling status until all files are not uploaded and assembled
Actual: Progressbar hidden once 1st file uploaded. So, assembling status not shown.

nextcloud-upload-2024-12-19_10.09.23.mp4

@skjnldsv
Copy link
Contributor Author

Will add tests and fix that use case, nice catch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants