-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submit, multiline and maxlength support #1465
Add submit, multiline and maxlength support #1465
Conversation
skjnldsv
commented
Oct 13, 2020
•
edited
Loading
edited
- Added multiline prop
- multiline false is looking like a default input, can still span multilines, but not required
- multiline true is looking like a textarea
- Added enter handlers
- enter = submit if multiline is false, new line if true
- shift + enter = new line
- ctrl + enter = submit
- Added maxlength support
- Updated docs
972debc
to
5c13d4d
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
5c13d4d
to
82cc44c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good design-wise
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
4159908
to
474d0d9
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
474d0d9
to
c8fbece
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am late to the party... :-P
enter = submit if multiline is false, new line if true
Could this be made configurable so enter can also send if multiline is true? In general sending messages on Talk should be done when just pressing enter, but the message field should also be multiline.
Multiline is only the default visual. See first post
|
Oh, right, sorry 🤦 |