Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mention inlined and ellipsised #1475

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Make mention inlined and ellipsised #1475

merged 1 commit into from
Oct 15, 2020

Conversation

skjnldsv
Copy link
Contributor

Capture d’écran_2020-10-15_13-25-15
Capture d’écran_2020-10-15_13-28-28

@skjnldsv
Make mention inlined and ellipsised
3250be6 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Oct 15, 2020
@skjnldsv skjnldsv self-assigned this Oct 15, 2020
ChristophWurst
ChristophWurst approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. my fav type of PR

@skjnldsv
Copy link
Contributor Author

Ah yes. my fav type of PR

I knew it the moment I requested reviews ;)

@skjnldsv skjnldsv merged commit 0cb973c into master Oct 15, 2020
@skjnldsv skjnldsv deleted the fix/mention-ellipsis branch October 15, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@julien-nc julien-nc Awaiting requested review from julien-nc

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @ChristophWurst @marcoambrosini