Add Caption component #1740
Add Caption component #1740
Conversation
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
added
3. to review
marcoambrosini
requested review from
nickvergessen,
ChristophWurst,
juliusknorr,
julien-nc and
skjnldsv
| --> | ||
|
|
||
| <template> | ||
| <div role="heading" class="app-navigation-caption"> |
There was a problem hiding this comment.
I'm a bit confused by this. We already have a Caption component for the navigation.
Is this component navigation only? It's also missing documentation.
I think the name should be more straightforward, and maybe the component should be in a dedicated section of the docs? Like 'Text', where we could also put the highlight component as well? 🤔
There was a problem hiding this comment.
Is this component navigation only
It's used in both navigation and sidebar in Talk
It's also missing documentation
Oopsss
I think the name should be more straightforward, and maybe the component should be in a dedicated section of the docs? Like 'Text', where we could also put the highlight component as well? thinking
Not sure I get this, quick call?
There was a problem hiding this comment.
Not sure I get this, quick call?
For transparency and posterity it would be cool to have the infos, decisions and so on here with the PR.
There was a problem hiding this comment.
@ma12-co what was the results of the call ? Can you summarize ?
There was a problem hiding this comment.
Waiting for @jancborchardt
Discussion here #1751
|
@ma12-co what's the difference with your other similarly titled PR ? #1739 |
That component is for use within actions only. |
skjnldsv
added
2. developing
|
closing in favor of #1863 |
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me