Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to floating-vue #2600

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Migrate to floating-vue #2600

merged 1 commit into from
Jul 27, 2022

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Apr 4, 2022

This migrates the popover library from v-tooltip to its successor floating-vue. There are no visual changes intended, so I don't provide any before/after screenshots.

The functions directly affected in the library are

  • Actions component
  • EmojiPicker component
  • ColorPicker component
  • DatetimePicker component
  • UserBubble component
  • Popover component
  • Avatar component
  • Tooltip directive

I checked that they still work as I think they should, but please check as well.

With the migration there come some breaking changes listed here: https://floating-vue.starpad.dev/migration/migration-from-v2.html#directive The most important one is the deprecation/renaming of some props, e.g.:

  • trigger to triggers
  • open to shown
  • boundariesElement to boundary
  • classes to popperClass

This is important to everyone using the Popover component directly, e.g. done in Talk @nickvergessen

@raimund-schluessler raimund-schluessler self-assigned this Apr 4, 2022
@raimund-schluessler raimund-schluessler added 2. developing Work in progress dependencies Pull requests that update a dependency file labels Apr 4, 2022
@raimund-schluessler raimund-schluessler force-pushed the fix/noid/floating-vue branch 5 times, most recently from 1983476 to 3b0f79d Compare April 5, 2022 21:31
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Apr 7, 2022
@raimund-schluessler raimund-schluessler added the breaking PR that requires a new major version label Apr 7, 2022
@raimund-schluessler raimund-schluessler force-pushed the fix/noid/floating-vue branch 2 times, most recently from a417d28 to 9a02189 Compare July 23, 2022 13:53
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: actions Related to the actions components feature: tooltip Related to the tooltip directive feature: emoji picker Related to the emoji picker component and removed 2. developing Work in progress labels Jul 23, 2022
@raimund-schluessler raimund-schluessler marked this pull request as ready for review July 23, 2022 14:11
@raimund-schluessler raimund-schluessler force-pushed the fix/noid/floating-vue branch 2 times, most recently from 0097587 to 7851612 Compare July 23, 2022 14:29
@marcoambrosini
Copy link
Contributor

you rock @raimund-schluessler :)

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@PVince81
Copy link
Contributor

to retest: avatar menu in Talk conversation which uses Popover with heavy workarounds to make sure it gets positioned properly despite the scroll and tooltip delay

Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the docs and works. I'd say let's merge and release v6.0.0-beta.0 so that we can upgrade and fix the breaking changes in the apps

@juliusknorr juliusknorr merged commit 5ac29c3 into master Jul 27, 2022
@juliusknorr juliusknorr deleted the fix/noid/floating-vue branch July 27, 2022 15:25
@@ -20,15 +20,12 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
import { VTooltip, options } from 'floating-vue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in talk we were setting the default container:

Tooltip.options.defaultContainer = '#content-vue'

But with floating-vue the options are not on the exported object anymore.
So can we also export the options Object?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background for defaultContainer: to make sure the tooltips stay visible even in fullscreen mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews breaking PR that requires a new major version dependencies Pull requests that update a dependency file feature: actions Related to the actions components feature: emoji picker Related to the emoji picker component feature: tooltip Related to the tooltip directive technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants