-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to floating-vue #2600
Migrate to floating-vue #2600
Conversation
1983476
to
3b0f79d
Compare
3b0f79d
to
d25fde5
Compare
d25fde5
to
7711c08
Compare
a417d28
to
9a02189
Compare
0097587
to
7851612
Compare
you rock @raimund-schluessler :) |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
7851612
to
f08754e
Compare
to retest: avatar menu in Talk conversation which uses Popover with heavy workarounds to make sure it gets positioned properly despite the scroll and tooltip delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in the docs and works. I'd say let's merge and release v6.0.0-beta.0 so that we can upgrade and fix the breaking changes in the apps
@@ -20,15 +20,12 @@ | |||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
* | |||
*/ | |||
import { VTooltip, options } from 'floating-vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in talk we were setting the default container:
Tooltip.options.defaultContainer = '#content-vue'
But with floating-vue the options are not on the exported object anymore.
So can we also export the options Object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background for defaultContainer: to make sure the tooltips stay visible even in fullscreen mode
This migrates the popover library from
v-tooltip
to its successorfloating-vue
. There are no visual changes intended, so I don't provide any before/after screenshots.The functions directly affected in the library are
Actions
componentEmojiPicker
componentColorPicker
componentDatetimePicker
componentUserBubble
componentPopover
componentAvatar
componentTooltip
directiveI checked that they still work as I think they should, but please check as well.
With the migration there come some breaking changes listed here: https://floating-vue.starpad.dev/migration/migration-from-v2.html#directive The most important one is the deprecation/renaming of some props, e.g.:
trigger
totriggers
open
toshown
boundariesElement
toboundary
classes
topopperClass
This is important to everyone using the
Popover
component directly, e.g. done in Talk @nickvergessen