-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 enhance actions focus trap #3028
Conversation
ef473b0
to
9d188ea
Compare
Not sure why, but the docs don't build/work. |
Locally, the styleguide looks good (and the example works). Maybe just a hiccup? |
@vinicius73 I hope you don't mind, I pushed a commit with my suggestions. If you disagree with them, just discard my commit. The docs still don't show up, though. |
I disagree just about |
Actions was just rewritten, I would like to know what you think needs to change. Let's see your PR😉 |
add scoped default slot and expose clearFocusTrap Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
51b00d4
to
5d8360b
Compare
Underlying issue was solved with #3030. |
Related to #3021
clearFocusTrap
Actions