Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to render x items outside an Actions menu #3060

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 18, 2022

Capture d’écran_2022-08-18_11-10-56

Currently, it's hardcoded, meaning we are not hecking the available space and changing the inline accordingly.
Might come later, but this is a good enough starting point

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components labels Aug 18, 2022
@skjnldsv skjnldsv added this to the 6.0.0 milestone Aug 18, 2022
@skjnldsv skjnldsv self-assigned this Aug 18, 2022
@skjnldsv skjnldsv requested review from a team, PVince81, artonge and szaimen and removed request for a team August 18, 2022 09:14
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv

This comment was marked as resolved.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/actions-inline branch 2 times, most recently from e06907e to 5759e57 Compare August 18, 2022 10:02
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Copy link
Contributor

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff

@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Aug 18, 2022

I think it works as it should, I will do a review later.

But without automatically adjusting to the available size, the usefulness is a bit limited, to be honest. You could achieve the same already by simply putting your inline actions as Buttons next to the Actions if you anyway have to specify an inline button count.

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Aug 18, 2022

But without automatically adjusting to the available size, the usefulness is a bit limited, to be honest. You could achieve the same already by simply putting your inline actions as Buttons next to the Actions if you anyway have to specify an inline button count.

Baby steps :)
It gives much more flexibility and is far easier to adjust that prop than copying/moving ButtonVue to Actions back and forth.
Devs are also free to automatically implement the reactivity on the area they're usint the Actions component and therefore adjusting the inline prop accordingly.

Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested in the docs and works. Awesome stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants