Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NcEmptyContent used inside NcModal #3253

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix NcEmptyContent used inside NcModal #3253

merged 1 commit into from
Sep 14, 2022

Conversation

nickvergessen
Copy link
Contributor

Before After
Bildschirmfoto vom 2022-09-14 12-49-50 Bildschirmfoto vom 2022-09-14 12-48-53

@nickvergessen
Fix NcEmptyContent used inside NcModal
9a64403 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component feature: emptycontent Related to the emptycontent component labels Sep 14, 2022
@nickvergessen nickvergessen added this to the 7.0.0 milestone Sep 14, 2022
@nickvergessen nickvergessen requested review from GretaD, marcoambrosini, a team, PVince81, artonge and Pytal and removed request for a team September 14, 2022 10:50
@nickvergessen nickvergessen mentioned this pull request Sep 14, 2022
Merged
2 tasks
PVince81
PVince81 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 2913407 into master Sep 14, 2022
@PVince81 PVince81 deleted the bugfix/noid/empty-content-in-modal branch September 14, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: emptycontent Related to the emptycontent component feature: modal Related to the modal component
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @PVince81 @szaimen