-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcRichText
) add support of GFM (extended markdown)
#4365
Conversation
One thing I am not sure about is whether we want to different Markdown flavors, as this can be quite confusing. Maybe we should make sure NcRichText and Text supports the same Markdown dialect? |
That could be the best way to do that. |
Link to documentation:
So, GFM is based on CMS, including such extensions as autolink, strikethrough, tables and tasklists. I see they're activated in Text app as well: https://github.com/nextcloud/text/blob/cd39a0decac0a6f003d4bddff22faa70c3e71ae5/src/markdownit/index.js#L13-L16 From that point, flavor would be the same, although we might need to align syntax for some extensions (and not sure this make sense for the tables, as Text has injected table editor, which would be an overkill for Talk input) To ensure we're supporting the same syntax, we could try to base NcRichText tests on https://spec.commonmark.org/0.30/spec.json somehow, but I don't think it's needed, as libraries based on the same specs |
479ed3b
to
e5d0269
Compare
cf65011
to
d0bd807
Compare
Because of using some React functionality at Apart from it, a basic extended markdown is working and evem possible to backport for master release, although I don't know, if it's considered as breaking change or not (original behavior was untouched, this goes under new functionality) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
d0bd807
to
42cb82e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, seems to work fine. Some comments
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
dffa03a
to
ce2389d
Compare
Aj, we forgot to put it into the 8.5.0 changelog 🙈 |
🙈 sorry, looks like this one was excluded by our config nextcloud-vue/.github/release.yml Line 11 in 99a7c57
|
☑️ Resolves
~~
-- | --
- [ ]
- [x]
🖼️ Screenshots
markdown-checkboxes.webm
In Talk messages:
🚧 Tasks
🏁 Checklist