Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichText) - don't populate a first newline to properly parse blockqoute tags #4470

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix(NcRichText) - don't populate a first newline to properly parse blockqoute tags #4470

merged 2 commits into from
Aug 25, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 25, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-08-25 10-16-16 Screenshot from 2023-08-25 10-15-25

🚧 Tasks

  • Code review
  • Manual testing

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: richtext Related to the richtext component labels Aug 25, 2023
@Antreesy Antreesy added this to the 8.0.0 milestone Aug 25, 2023
@Antreesy Antreesy self-assigned this Aug 25, 2023
nickvergessen
nickvergessen approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug in talk

@Antreesy
don't populate a first newline to properly parse blockqoute tags
59b9c5c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/keep-newlines-markdown branch from 2787345 to 9327bcc Compare August 25, 2023 12:26
@Antreesy
Copy link
Contributor Author

Rebased onto master, added cypress tests

@Antreesy
add cypress tests for common markdown use cases
cf792b5 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/keep-newlines-markdown branch from 9327bcc to cf792b5 Compare August 25, 2023 12:30
@Antreesy Antreesy mentioned this pull request Aug 25, 2023
Merged
DorraJaouad
DorraJaouad approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patterns seem right :) . I am just not sure if condensing each two new lines having ">" each into one line is intentional ( if there is n, an odd number of ">", then it is (n+1)/2 new lines) .
Tested and it works as expected otherwise .

@Antreesy Antreesy merged commit 8aba923 into master Aug 25, 2023
15 checks passed
@Antreesy Antreesy deleted the fix/noid/keep-newlines-markdown branch August 25, 2023 15:12
@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 25, 2023 •
edited
Loading

I am just not sure if condensing each two new lines having ">" each into one line is intentional

That's for empty lines in quote notation:

> quote line 1
>
> line 3

@Antreesy Antreesy mentioned this pull request Sep 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component regression Regression of a previous working feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad