-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop propagation of keyboard navigation in a number of components #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
Something isn't working
feature: popover
Related to the popovermenu component
feature: app-navigation
Related to the app-navigation component
feature: select
Related to the NcSelect* components
feature: app-sidebar
Related to the app-sidebar component
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
labels
Sep 4, 2023
ShGKme
requested review from
raimund-schluessler,
JuliaKirschenheuter,
Pytal,
skjnldsv,
szaimen and
susnux
September 6, 2023 14:17
skjnldsv
approved these changes
Sep 6, 2023
Pytal
requested changes
Sep 6, 2023
GretaD
approved these changes
Sep 7, 2023
you can Dissmiss changes requested by pytal, if its delivered and they dont review it on time |
Pytal
approved these changes
Sep 7, 2023
ShGKme
force-pushed
the
fix/stop-keyboard-navigation
branch
from
September 7, 2023 15:43
4c7ebb4
to
da9582d
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/stop-keyboard-navigation
branch
from
September 7, 2023 15:56
da9582d
to
2cb60f2
Compare
Rebased onto master with fixtup, no other changes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
bug
Something isn't working
feature: app-navigation
Related to the app-navigation component
feature: app-sidebar
Related to the app-sidebar component
feature: popover
Related to the popovermenu component
feature: select
Related to the NcSelect* components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
#4406 was merged too early, it solved only problems with Arrows in general, but not ESC.
Arrows and ESC are used for keyboard navigation in some components. But the keydown event is not stopped. As a result, arrows and ESC not only manipulate such components but also are handled globally.
For example:
NcModal
:NcModal
should only close popover, but also close the ModalNcModal
To test add a global event listener and check console:
🖼️ Screenshots
🚧 Tasks
NcModal
.stop
modifier:NcAppSidebar
nameEditable
NcAppSidebarTabs
NcInputConfirmCancel
NcSelect
: add interceptor viamapKeydown
to stop propagation when select is openNcPopover
: manually add keydown event listener similar to how focus trap is added. It can be cleaner with an additional wrapper of popover contentNcPopover
:NcActions
NcEmojiPicker
NcUserBubble
NcColorPicker
NcDatetimePicker
Ignored:
NcHeaderMenu
:NcListItem
:Additional discussion
Both this PR and #4406 fixes Arrows navigation in Sidebar tabs being in a modal viewer. But they do it in a different way:
NcModal
from switching slides by any not stopped arrows outside the modalI'd keep both PRs but we can revert #4406.
For example, if we want to switch slides in Viewer when the focus is on Tab panel content div.
🏁 Checklist