-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcDialog): New component (moved from @nextcloud/dialogs
)
#4550
Conversation
Still the buttons should not appear at the very bottom. Is this possible? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@szaimen would you mind if we do a design review session later (maybe schedule it with the design team) and for the beginning just merge it as is? |
@szaimen reworked the small dialogs, now it looks like normal dialogs: |
7e29abc
to
bd05641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now from design perspective :)
However I guess the a11y team should look over it as it might not be 100% accessible?
cc @JuliaKirschenheuter @ShGKme @Pytal
bd05641
to
745dc22
Compare
…odal` component Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… as the base Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
745dc22
to
b1164ed
Compare
☑️ Resolves
AppSettingsDialog
does scroll the section list when clicking on entry #4348 (fixed by migrating AppSettingsDialog to NcDialog base)@nextcloud/dialogs
) #4415 (without Typescript and fancy<script setup>
).Introduces NcDialog as a generic base Dialog component, while NcModal is simply a base for modals like the viewer, NcDialog provides a convenient interface to define dialogs (see example).
The new FilePicker of the
@nextcloud/dialogs
package is based on top of it.🖼️ Screenshots
One example dialog:
🏁 Checklist