Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Rename Datetime to DateTime in component names #4560

Merged
merged 1 commit into from
Sep 24, 2023
Merged

chore!: Rename Datetime to DateTime in component names #4560

merged 1 commit into from
Sep 24, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 23, 2023

☑️ Resolves

Fix inconsistent naming

  • NcDatetime is now called NcDateTime (not yet released to ok)
  • NcDatetimePicker is now called NcDateTimePicker (breaking, but we make it consistent with DateTimeNative)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
chore!: Rename Datetime to DateTime in component names
eb2e109 
* `NcDatetime` is now called `NcDateTime`
* `NcDatetimePicker` is now called `NcDateTimePicker`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews breaking PR that requires a new major version labels Sep 23, 2023
st3iny
st3iny approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick 😄

raimund-schluessler
raimund-schluessler previously requested changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is inconsistent with the other component names.

Edit: Sorry, I see you aimed to make it consistent. However, in #4533 I jus did the opposite. 🙈

@susnux
Copy link
Contributor Author

susnux commented Sep 23, 2023

But what is a Datetime? It is a Date and Time picker so I would say DateTimePicker makes more sense.
At least it is more consistent with all other names like AppNavigation (and not Appnavigation) etc.

@raimund-schluessler
Copy link
Contributor

But what is a Datetime? It is a Date and Time picker so I would say DateTimePicker makes more sense. At least it is more consistent with all other names like AppNavigation (and not Appnavigation) etc.

I considered datetime to be one word, but that is probably a German bias. I am fine with whatever consistent solution we use. We just have to revert and adjust it for next as well then.

@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Sep 23, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 24, 2023
@skjnldsv
Copy link
Contributor

DateTime is used in javascript
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat

@skjnldsv skjnldsv merged commit f47afd4 into master Sep 24, 2023
14 checks passed
@skjnldsv skjnldsv deleted the fix/naming-of-date-time branch September 24, 2023 10:16
@Pytal Pytal mentioned this pull request Sep 28, 2023
Merged
@st3iny st3iny mentioned this pull request Oct 5, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@st3iny st3iny st3iny approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish breaking PR that requires a new major version
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @raimund-schluessler @skjnldsv @st3iny