Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Make isMobileState PURE so it can be treeshaken if not used #4595

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 2, 2023

☑️ Resolves

Currently it otherwise will always be imported because the treeshake algorithm can not decide if running the Vue constructor has any sideeffects.

(saves a few bytes on projects not using it)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

…used

Currently it otherwise will always be imported because the treeshake algorithm can not decide if running the Vue constructor has any sideeffects.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added the 3. to review Waiting for reviews label Oct 2, 2023
@raimund-schluessler raimund-schluessler merged commit 461d332 into master Oct 3, 2023
14 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/make-is-mobile-state-pure branch October 3, 2023 06:05
@Pytal Pytal added the bug Something isn't working label Oct 6, 2023
@Pytal Pytal mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants