Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcCheckboxRadioSwitch): Restore wrapper element prop #4679

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(NcCheckboxRadioSwitch): Restore wrapper element prop #4679

merged 1 commit into from
Oct 20, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 20, 2023

Summary

  • Restore breaking prop removal 🙈

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
fix(NcCheckboxRadioSwitch): Restore wrapper element prop
ecbca63 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Oct 20, 2023
@Pytal Pytal added this to the 8.0.0 milestone Oct 20, 2023
@Pytal Pytal self-assigned this Oct 20, 2023
@Pytal Pytal requested a review from szaimen October 20, 2023 17:44
szaimen
szaimen approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot really judge the changes but fine by me

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 20, 2023
@Pytal Pytal merged commit 89048aa into master Oct 20, 2023
15 checks passed
@Pytal Pytal deleted the fix/restore-checkbox-wrapper branch October 20, 2023 17:47
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@szaimen szaimen szaimen approved these changes

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @AndyScherzinger @szaimen