Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove empty attributes values #4686

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix: remove empty attributes values #4686

merged 3 commits into from
Oct 23, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 23, 2023

☑️ Resolves

Error: Bad value ' ' for attribute target on element a: Browsing context name must be at least one character long.

🖼️ Screenshots

No visual changes

🚧 Tasks

  • NcAppNavigationItem: remove empty string target
  • NcNoteCard: use role="note" for non-alert card instead of empty role=""
  • Some components: refactor ternary with empty string else with Vue object class bingings

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
fix(NcAppNavigationItem): remove empty target attr
e9ead77 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(NcNoteCard): replace empty role with note by default
4984de0 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor: replace ternary with object-syntax in class bind
5101895 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: note-card Related to the note-card component labels Oct 23, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Oct 23, 2023
@ShGKme ShGKme self-assigned this Oct 23, 2023
@ShGKme ShGKme merged commit c18ed46 into master Oct 23, 2023
15 checks passed
@ShGKme ShGKme deleted the fix/empty-attr-values branch October 23, 2023 11:51
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-navigation Related to the app-navigation component feature: note-card Related to the note-card component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @raimund-schluessler @szaimen