-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcActions): hotfix for custom children #5178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These custom wrappers for NcAction*
are a pain. I know they are necessary sometimes, but they really interfere with how NcActions
works. And it got worse with the focus trap and a11y stuff.
However, the hotfix brings back the functionality for now, so 👍
I just had a few nitpicks for the language 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with styleguide only
d58b498
to
aa8b796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix DCO and the fixup
commments
|
08cbc01
to
22f02b7
Compare
Thats what I meant: Squash the commits and add the sign off^^ |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
22f02b7
to
5b951e5
Compare
/backport to next |
☑️ Resolves
In
NcActions
we check whatNcAction*
components were passed as direct children. But some apps (Text, Mail) passNcAction*
not as direct children ofNcActions
, but as a sub-child.The current
NcActions
implementation doesn't fully support this.inline
prop and incorrect render of single actionsNcAction*
interactive children (they are sub-children)Unfortunately, in Vue 2 it is not possible to easily fix. When render function is executed, children are not rendered yet, so we don't know if they are to render
NcAction*
components or not.This PR adds a hotfix that prevents component from being unusable. If children are not allowed custom components - consider menu a dialog with the default focus trap.
So the component works like it worked in the past. Yet it still has bad accessibility in this case.
🖼️ Screenshots
Docs
🚧 Tasks
NCActions
children limitationsdialog
if there are custom🏁 Checklist