fix(NcAppNavigationNewItem): bring back correct CSS class #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
=======================================
Coverage 39.34% 39.34%
=======================================
Files 139 139
Lines 3688 3688
Branches 810 810
=======================================
Hits 1451 1451
Misses 2021 2021
Partials 216 216 ☔ View full report in Codecov by Sentry. |
raimund-schluessler
requested review from
szaimen,
susnux,
Pytal,
ShGKme and
Antreesy
susnux
approved these changes
Jan 31, 2024
Antreesy
approved these changes
Jan 31, 2024
raimund-schluessler
deleted the
fix/5159/navigation-new-item-regression
branch
Merged
|
Mmmh. Still looks kind of out of place: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcAppNavigationNewItemthat I introduced in fix(NcAppNavigationItem): fix style when usingactiveprop #4989. Closes [v8.x] NcNavigationNewItem: Is this an accident? #5159.🖼️ Screenshots