Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split reference and smart picker functions from components #5218

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

juliusknorr
Copy link
Contributor

@juliusknorr juliusknorr commented Feb 6, 2024

This change allows importing reference widget registration methods without pulling a large dependency chain of vue components in right away. That way one can reduce the bundle size of entrypoints quite a bit when moving required components to be lazy imported.

For tables this brings down the entrypoint from 4MB to 16KB

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-02-06 at 14 45 28 Screenshot 2024-02-06 at 14 46 39

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@juliusknorr
Copy link
Contributor Author

Not entirely sure about the structure, which is any suggestions would be welcome to improve of course ;)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr marked this pull request as ready for review February 8, 2024 14:02
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Looks fine according to the code and the dist looks fine.

Not entirely sure about the structure, which is any suggestions would be welcome to improve of course ;)

Currently there is no better place, I think.

An alternative would be to add a new folder, add it to build and to package.exports. I'm also not a fun of the current "separate by file type" structure. But we can rethink it for v9 or v10.

@juliusknorr juliusknorr merged commit aaa4597 into master Feb 8, 2024
19 checks passed
@juliusknorr juliusknorr deleted the enh/reference-split branch February 8, 2024 17:48
@juliusknorr
Copy link
Contributor Author

/backport to next

Copy link

backportbot bot commented Feb 12, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5218/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c57090

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5218/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv mentioned this pull request Feb 20, 2024
@juliusknorr
Copy link
Contributor Author

/backport to next

Copy link

backportbot bot commented Aug 6, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5218/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c57090

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5218/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr
Copy link
Contributor Author

Already present in next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants