-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Split reference and smart picker functions from components #5218
Conversation
Not entirely sure about the structure, which is any suggestions would be welcome to improve of course ;) |
7d5b867
to
2e5e06c
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2e5e06c
to
93c5709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Looks fine according to the code and the dist
looks fine.
Not entirely sure about the structure, which is any suggestions would be welcome to improve of course ;)
Currently there is no better place, I think.
An alternative would be to add a new folder, add it to build and to package.exports
. I'm also not a fun of the current "separate by file type" structure. But we can rethink it for v9 or v10.
/backport to next |
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5218/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c57090
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5218/next Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to next |
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5218/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c57090
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5218/next Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Already present in next |
This change allows importing reference widget registration methods without pulling a large dependency chain of vue components in right away. That way one can reduce the bundle size of entrypoints quite a bit when moving required components to be lazy imported.
For tables this brings down the entrypoint from 4MB to 16KB
🖼️ Screenshots
🏁 Checklist