feat(NcSelect): Add required attribute for native form validation
#5225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
2. developing
Pytal
force-pushed
the
feat/select-form-validation
branch
from
404b611
to
c621df3
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/select-form-validation
branch
from
c621df3
to
5d8ef9d
Compare
Pytal
added
enhancement
susnux
approved these changes
Feb 9, 2024
4 tasks
ShGKme
approved these changes
Feb 9, 2024
Comment on lines
+992
to
+998
| inputRequired() { | ||
| if (!this.required) { | ||
| return null | ||
| } | ||
| // The <input> itself does not have any value so we set the `required` attribute conditionally | ||
| return this.value === null || (Array.isArray(this.value) && this.value.length === 0) | ||
| }, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🏁 Checklist