-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] fix(NcActionInput): listen to correct events #5231
Conversation
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
I haven't tested, but it looks like input
and change
events doesn't work anymore with this PR. As they only proxied the same native events with native Event
payload, we probably can just remove them from the emits
declaration to bring them back. (Will work as a part of v-bind="$attrs"
)
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@ShGKme I removed them from the |
Component is missing Once event listener is set by Probably, we should add |
Setting |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
76d4dcb
to
ff8486a
Compare
@ShGKme I added |
Yes, but using |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Done. |
☑️ Resolves
NcActionInput
to listen to the correct events of its child components. Before, the events of its childcomponents would not trigger an update of the model value.NcActionInput
does not listen to correct events #5229