Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): compensate added margin for list items #5260

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix(NcListItem): compensate added margin for list items #5260

merged 1 commit into from
Feb 19, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

Tested against Talk

🏚️ Before 🏡 After
Screenshot from 2024-02-19 10-47-38 Screenshot from 2024-02-19 10-48-57

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcListItem): compensate added margin for list items
8045f82 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review Waiting for reviews regression Regression of a previous working feature feature: list-item Related to the list-item component labels Feb 19, 2024
@Antreesy Antreesy added this to the 8.7.0 milestone Feb 19, 2024
@Antreesy Antreesy self-assigned this Feb 19, 2024
ShGKme
ShGKme approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative - make the outline inside the list item to have true 100% width. I'm almost sure, we did it in a similar place already...

@Antreesy Antreesy merged commit f943d49 into master Feb 19, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/5198/list-item-cropped branch February 19, 2024 19:06
@skjnldsv skjnldsv mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews feature: list-item Related to the list-item component regression Regression of a previous working feature
Projects
None yet
Milestone
8.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @emoral435