feat(NcAppSidebar): Add subname slot
#5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e item Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
enhancement
susnux
requested review from
raimund-schluessler,
skjnldsv,
Pytal and
emoral435
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/app-sidebar-add-subname-slot
branch
from
470a5be
to
d84e3d5
Compare
Pytal
approved these changes
Feb 22, 2024
skjnldsv
approved these changes
Feb 22, 2024
Closed
Merged
|
/backport to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This adds a
subnameslot for the same purpose as thesubnameprop, but this allows more advanced usage.My use case: Add an icon with alt text / aria label.
Nextcloud files does not use the
starredbutton anymore (design decision) but simply an action menu entry + an ⭐ icon on the subname.The problem is that the star icon (just a unicode symbol) is not announced by screen readers, so we need some accessible alternative. Fixed by allowing inline content as the slot content.
To implement this I also added an
inlineprop to the SVG icon wrapper to allow it to render icons inline (this is BTW something I really often saw people "hack" into the component usingdeepselectors to get rid of themin-widthandmin-height).🖼️ Screenshots
Inline icon:
App sidebar:
🏁 Checklist
nextrequested with a Vue 3 upgrade