fix(NcRichContenteditable): disable global allowSpaces tribute option #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tributejs library doesn't support allowSpaces as a collection option, only as a global one. As we need it only for mentions ('@' trigger), the best option for now is to disable it completely
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
3. to review
nickvergessen
approved these changes
Feb 28, 2024
DorraJaouad
approved these changes
Feb 28, 2024
Yep |
ShGKme
approved these changes
Feb 28, 2024
|
/backport to next |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Important
Mentions couldn't be searched with spaces in uid or as a
name surname🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade