Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigationItem): Fix uncollapsible entry #5456

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Apr 6, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Apr 6, 2024
@Pytal Pytal added this to the 8.11.2 milestone Apr 6, 2024
@Pytal Pytal self-assigned this Apr 6, 2024
@Pytal Pytal enabled auto-merge April 6, 2024 01:35
@Pytal Pytal merged commit b671917 into master Apr 8, 2024
18 checks passed
@Pytal Pytal deleted the fix/reactive-nav-item-collapse branch April 8, 2024 13:10
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks!

@Pytal
Copy link
Contributor Author

Pytal commented Apr 8, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Favorites in Files navigation not expandable anymore
4 participants