Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAvatar): support in-app router links for contact menu #5477

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(NcAvatar): support in-app router links for contact menu #5477

merged 1 commit into from
Apr 10, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 10, 2024 •
edited by Antreesy
Loading

☑️ Resolves

  • Support RouterLink for NcAvatar contact's menu, same as for links in NcRichText
  • Also, do not render user status as a link

🖼️ Screenshots

For this place in Talk:

image

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme
fix(NcAvatar): support in-app router links for contact menu
f5ce1a1 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Apr 10, 2024
@ShGKme ShGKme self-assigned this Apr 10, 2024
@ShGKme ShGKme mentioned this pull request Apr 10, 2024
Merged
Antreesy
Antreesy approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Talk

@Antreesy Antreesy merged commit 0a0adc3 into master Apr 10, 2024
18 checks passed
@Antreesy Antreesy deleted the feat/NcAvatar--router-link-support-for-contacts-menu branch April 10, 2024 13:53
@Antreesy
Copy link
Contributor

/backport to next

@backportbot backportbot bot mentioned this pull request Apr 10, 2024
Merged
2 tasks
@ShGKme ShGKme mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@susnux susnux susnux approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @Antreesy @susnux